Lint upstream as a normal unit test #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
force-pushed
the
blampe/upstream-lint
branch
from
7cd6c4d to
c2e930a
Compare
5 tasks
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4918 +/- ##
=======================================
Coverage 24.41% 24.41%
=======================================
Files 360 360
Lines 143270 143270
=======================================
Hits 34984 34984
Misses 108187 108187
Partials 99 99 ☔ View full report in Codecov by Sentry. |
t0yv0
reviewed
Dec 16, 2024
| @@ -493,9 +494,13 @@ var namespaceMap = map[string]string{ | |||
| "aws": "Aws", | |||
| } | |||
|
|
|||
| var _nslock = sync.Mutex{} | |||
There was a problem hiding this comment.
Curious what happened here, we ran awsMember call from multiple goroutines?
There was a problem hiding this comment.
That's probably because of all the t.Parallel introduced into the tests? Interesting.
t0yv0
approved these changes
Dec 16, 2024
|
Assuming the upstream waf tests are unrelated. |
|
This PR has been shipped in release v6.66.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last job in
extraTestsby making it a standard unit test.Currently the job runs without caching and takes upwards of 30-40 minutes because it re-compiles everything from scratch. This makes it the long poll when sharding is turned on.
By running with the rest of our tests it can benefit from caching. Locally the test takes only ~20s.
This is run during unit tests, which still take about ~5 minutes before and after this change. They're actually slightly faster because I parallelized some of them while I was in here.